Skip to content

fix(react): hide livestream layout fullscreen button when fullscreen is unsupported#2112

Merged
jdimovska merged 1 commit intomainfrom
hide-fullscreen
Feb 6, 2026
Merged

fix(react): hide livestream layout fullscreen button when fullscreen is unsupported#2112
jdimovska merged 1 commit intomainfrom
hide-fullscreen

Conversation

@jdimovska
Copy link
Contributor

@jdimovska jdimovska commented Feb 6, 2026 •
edited by coderabbitai bot
Loading

💡 Overview

This PR ensures the livestream layout fullscreen button is only shown when requestFullscreen is available.

Summary by CodeRabbit

  • Bug Fixes
    • Improved fullscreen button reliability by preventing errors when fullscreen is unavailable or unsupported.

@jdimovska jdimovska requested a review from oliverlaz February 6, 2026 13:07
@jdimovska jdimovska marked this pull request as ready for review February 6, 2026 13:07
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Latest commit: b8fa8ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The LivestreamLayout component was updated to safely check for the presence of both the participantViewElement and its requestFullscreen capability before rendering the fullscreen button. This adds necessary guards to prevent runtime errors when these properties are unavailable.

Changes

Cohort / File(s) Summary
Fullscreen Safety Enhancement
packages/react-sdk/src/core/components/CallLayout/LivestreamLayout.tsx		 Added participantViewElement to context extraction and enhanced fullscreen button rendering logic with guards to verify element existence and requestFullscreen API availability before use.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through code with care,
Checking if the fullscreen's there—
No crashes now when elements fade,
Safe guards ensure the path is made! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: hiding the fullscreen button in livestream layout when fullscreen is unsupported.
Description check ✅ Passed The description includes only the Overview section; the template requires Implementation notes and ticket/docs references, but the provided content is sufficient to understand the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hide-fullscreen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jdimovska jdimovska merged commit f436b01 into main Feb 6, 2026
15 checks passed
@jdimovska jdimovska deleted the hide-fullscreen branch February 6, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverlaz oliverlaz oliverlaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdimovska @oliverlaz